Build with SvelteKit packager #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walledgarden
approved these changes
Dec 21, 2023
* Components are now written in TypeScript, avoiding the need to maintain and test separate type definitions. * Migrated docs site to use SvelteKit and Bootstrap 5. * Switched from Prism to Highlight.js for code syntax highlighting. * Enabled Prettier to autoformat code. * Switched from Jest to Vitest for tests. * Separate `gh-pages` branch is now used to deploy docs so autogenerated files don't have to be committed to master branch. * Added contributing instructions file. These changes should make it a lot easier to build and test the project, lowering the barrier for contributions and future maintenance. Closes #313, closes #311
|
Amazing work @theodorejb ! This PR would clean up lots of issues with this repo, @Cweili do you think you could find the time to review and get this merged? Would be highly appreciated :) |
|
@theodorejb Excellent work! I believe what we currently lack is some test cases to achieve complete coverage. |
Merged
|
@Cweili Thanks! I don't believe coverage has actually decreased; it's that |
|
Released with v4. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-pagesbranch is now used to deploy docs so autogenerated files don't have to be committed to master branch (this may require updating the GitHub Pages Source repository setting).These changes should make it a lot easier to build and test the project, lowering the barrier for contributions and future maintenance.
Closes #313, closes #311