Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using source svelte files when building docs #312

Closed
wants to merge 1 commit into from
Closed

Using source svelte files when building docs #312

wants to merge 1 commit into from

Conversation

marekdedic
Copy link
Contributor

Closes #311

I tried just uncommenting the <script> tag and copying over the bundle, but that triggers some svelte error and you should use svelte source files anyway...

@Cweili
Copy link
Owner

Cweili commented Nov 23, 2023

The reason why I use the published version in the documentation is that I want to test whether the built version can be properly imported and used in the project. Is it possible to import svelte-fa in a monorepo-like way?

@marekdedic
Copy link
Contributor Author

Is it possible to import svelte-fa in a monorepo-like way?

It would be, but it would be much more complicated unfortunately, at least as far as my understanding of it goes - because when you are actually using it, rollup reads the package.json of svelte-fa and uses the source svelte files... So doing it in a monorepo fashion would probably mean really separating the docs and the lib into 2 packages with their own package.json and so on...

@Cweili
Copy link
Owner

Cweili commented Nov 23, 2023

Or perhaps we can also try to provide a "development" mode and a "product" mode for documentation

@marekdedic
Copy link
Contributor Author

That would actually be great, but given how it's imported in totally different ways, I don't see how to do that (but I have almost no experience with rollup and svelte bundling in general...)

@Cweili Cweili force-pushed the master branch 2 times, most recently from bc3db1d to 0978bac Compare January 5, 2024 08:22
@Cweili
Copy link
Owner

Cweili commented Jan 5, 2024

Solved by #315 .
Thanks!

@Cweili Cweili closed this Jan 5, 2024
@marekdedic marekdedic deleted the docs-local-version branch January 5, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add way to locally preview changes
2 participants