Fixed Issues #274
Merged
Fixed Issues #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed : Access to a protected member _cache of a client class.
This was
linked to
issues
Oct 28, 2021
This was
linked to
issues
Oct 28, 2021
Dhruvacube
requested changes
Oct 28, 2021
| @@ -35,7 +35,10 @@ def votedTopgg(ctx): | |||
| headers={"Authorization": topken}, | |||
| ) | |||
| try: | |||
| a_list = True if a.json().get("voted") >= 1 else False | |||
| if a.json().get("voted") >= 1: | |||
There was a problem hiding this comment.
hey @Pagasis no need to use if expression here, it would be a memory inefficient then, here remove the if and else and do this.
a_list = a.json().get("voted", False)| @@ -2,7 +2,6 @@ | |||
| import io | |||
| import os | |||
| import platform | |||
| import random | |||
| from random import choice | |||
There was a problem hiding this comment.
here doing still won't fix this issue, here just change the filename to random_fun_games.py to fix this.
| if str(ctx.message.author.id) in c.json().get("hasVoted24", False) | ||
| else False | ||
| ) | ||
| if str(ctx.message.author.id) in c.json().get("hasVoted24", False): |
There was a problem hiding this comment.
here also no need to do this if and else.
just do
c_list = str(ctx.message.author.id) in c.json().get("hasVoted24")
|
Yeah, i have changed them, you may merge it! |
|
@all-contributors please add @Pagasis for Maintenance |
|
I've put up a pull request to add @Pagasis! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues :
#237 #238 #242 #243 #244 #245
I have also fixed two occurrences of issue # 248 but not mentioning as the whole issue wasn't fixed.
Please consider for hacktoberfest 😄.