Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PYL-E1133) Non-iterable value used in an iterating context #247

Closed
Dhruvacube opened this issue Oct 19, 2021 · 6 comments · Fixed by #274
Closed

(PYL-E1133) Non-iterable value used in an iterating context #247

Dhruvacube opened this issue Oct 19, 2021 · 6 comments · Fixed by #274
Assignees
Milestone

Comments

@Dhruvacube
Copy link
Member

Description

A non-iterable value is being used in an iterating context, For example, a non-iterable value being passed into a for loop. This will raise a TypeError.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/The-4th-Hokage/yondaime-hokage/issue/PYL-E1133/occurrences/

@Pagasis
Copy link
Contributor

Pagasis commented Oct 27, 2021

@Dhruvacube
Copy link
Member Author

@Pagasis
Copy link
Contributor

Pagasis commented Oct 27, 2021

Oh sorry, yeah so self.oxistates is returning a list, but
https://github.com/The-4th-Hokage/yondaime-hokage/blob/08c20fec8ad28353559291da69c505e3d313b184/minato_namikaze/bot_files/lib/mendeleev/models.py#L235-L239
what is the data type of self._oxidation_states , as you are looping it inside the function oxistates. Like maybe it is causing the issue!

@Dhruvacube
Copy link
Member Author

ohhhh wait @Pagasis sorry for the inconvenience caused but its a false positive issue, actually the issue was raised using the deepsource and I didn't see it, so sorry

@Dhruvacube
Copy link
Member Author

_oxidation_states

actually _oxidation_states is a foreign key object

@Pagasis
Copy link
Contributor

Pagasis commented Oct 27, 2021

ohhhh wait @Pagasis sorry for the inconvenience caused but its a false positive issue, actually the issue was raised using the deepsource and I didn't see it, so sorry

No problem 😄

@Dhruvacube Dhruvacube added this to the v2.0 milestone Oct 28, 2021
@Dhruvacube Dhruvacube added the enhancement New feature or request label Oct 28, 2021
@Dhruvacube Dhruvacube linked a pull request Oct 28, 2021 that will close this issue
@Dhruvacube Dhruvacube added false-positive and removed enhancement New feature or request labels Oct 31, 2021
@Dhruvacube Dhruvacube added this to v2.0 Jul 7, 2024
@Dhruvacube Dhruvacube moved this to Done in v2.0 Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants