Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting fix #918

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Sorting fix #918

merged 5 commits into from
Jul 29, 2022

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jul 29, 2022

Replaces #916 (Thank you the-frey)

Rebased and using suggestion. Made mods myself to get this out faster. And unified it with #917 so both changes are together

@ethanfrey ethanfrey requested a review from alpe as a code owner July 29, 2022 06:35
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #918 (90a3781) into main (f5804fc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          51       51           
  Lines        6198     6204    +6     
=======================================
+ Hits         3670     3674    +4     
- Misses       2262     2263    +1     
- Partials      266      267    +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 88.23% <ø> (-0.34%) ⬇️
x/wasm/keeper/msg_dispatcher.go 88.88% <100.00%> (+0.65%) ⬆️

@ethanfrey ethanfrey merged commit 2886092 into main Jul 29, 2022
@ethanfrey ethanfrey deleted the sorting-fix branch July 29, 2022 07:00
@ueco-jb
Copy link

ueco-jb commented Jul 29, 2022

https://github.com/CosmWasm/wasmd#compatibility also needs a new entry if you're going to release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants