Add sorting fix from terra devs #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _, e := range events { | ||
| attributes := e.Attributes | ||
| sort.SliceStable(attributes, func(i, j int) bool { | ||
| return bytes.Compare([]byte(attributes[i].Key), []byte(attributes[j].Key)) == -1 |
There was a problem hiding this comment.
Suggested change
| return bytes.Compare([]byte(attributes[i].Key), []byte(attributes[j].Key)) == -1 | |
| return attributes[i].Key < attributes[j].Key |
|
I am unsure this is needed. Please DM me where any possible reordering is possible one we restrict to just wasm messages. Otherwise, I would avoid this complexity. |
Merged
|
Replacing this with #918 Thank you very much for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be that @assafmo's fix is enough, but also contributing this upstream as we are going to roll with it on a fork. Credit of course goes to the Terra folks for spotting the non-determinism issue there.