Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference standard IBC events #629

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Reference standard IBC events #629

merged 1 commit into from
Oct 7, 2021

Conversation

ethanfrey
Copy link
Member

Closes #593

@ethanfrey ethanfrey requested a review from alpe October 7, 2021 09:12
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #629 (1b79f81) into master (5e88752) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   60.51%   60.47%   -0.04%     
==========================================
  Files          48       48              
  Lines        5270     5270              
==========================================
- Hits         3189     3187       -2     
- Misses       1859     1860       +1     
- Partials      222      223       +1
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 86.97% <0.00%> (-0.34%) ⬇️

alpe
alpe approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice summary!

@ethanfrey ethanfrey merged commit 50458e0 into master Oct 7, 2021
@ethanfrey ethanfrey deleted the 593-finalize-ibc-events branch October 7, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalize IBC Events
2 participants
@ethanfrey @alpe