Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize IBC Events #593

Closed
ethanfrey opened this issue Aug 16, 2021 · 1 comment · Fixed by #629
Closed

Finalize IBC Events #593

ethanfrey opened this issue Aug 16, 2021 · 1 comment · Fixed by #629
Milestone

Comments

@ethanfrey
Copy link
Member

These are not yet defined in EVENTS.md.
They were not critical to finalise for 0.18, as other cosmwasm contracts cannot listen to those (so they are not contract API breaking), but it is good to document and stabilise those before a 1.0 release

@ethanfrey ethanfrey added this to the 0.19.0 milestone Aug 16, 2021
@alpe alpe modified the milestones: v0.19.0, v0.20.0 Sep 15, 2021
@ethanfrey
Copy link
Member Author

On reflection, contracts will never execute the ibc entry points except in very contrived examples.

The ibc handlers already have well-defined events for IBC messages (which are used by the relayers to work). We can just reference those events and not generate a specific cosmwasm event. You can already query events on port_id and/or channel_id which should be enough to track a contract.

Unless there are other comments, I would just fix the doc to reference standard IBC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants