-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm querier integration tests #273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 73.32% 74.17% +0.85%
==========================================
Files 27 27
Lines 2339 2339
==========================================
+ Hits 1715 1735 +20
+ Misses 511 485 -26
- Partials 113 119 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌷 Very nice.
// BondedDenom -> Atom | ||
// Delegation -> With detailed info | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pp: there was quite some effort to setup the test. I was wondering if a staking keeper mock would be an easier fit or what was your intention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to see how the query callbacks from the contracts really work.
I have a contract that will take the user input and use that to trigger a query via Querier
. This allows us to see what a contract would see. And we need to see what would happen against a real staking keeper (as there are some bugs... we want to fix how those work, full stack for compatibility).
Closes #269
WasmQuery::Smart
andWasmQuery::Raw
viaNot done:
[]{Key, Value}
return value...) - this is moved to Update RawQuery return value #275