Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RawQuery return value #275

Closed
2 of 4 tasks
ethanfrey opened this issue Oct 6, 2020 · 1 comment · Fixed by #277
Closed
2 of 4 tasks

Update RawQuery return value #275

ethanfrey opened this issue Oct 6, 2020 · 1 comment · Fixed by #277
Assignees
Milestone

Comments

@ethanfrey
Copy link
Member

ethanfrey commented Oct 6, 2020

It takes a key as input, but returns []struct{Key, Value}. We only seems to use res[0].Value (also in the client)

  • Verify if there are any cases where we return multiple models
  • Update the RawQuery callback for contracts (tested in reflect_test.go::TestMaskReflectWasmQueries)
  • Update the RawQuery call for clients (also rest and cli bindings)
  • Update doc strings as needed
@ethanfrey ethanfrey added this to the v0.11.0 milestone Oct 6, 2020
@ethanfrey
Copy link
Member Author

Okay, we do need to return []Model for QueryMethodContractStateAll which returns all state.

We do not need to use the same return value for QueryMethodContractStateRaw.

I will maintain the behavior for all, but change it for raw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant