Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Wasmer references #1599

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Remove Wasmer references #1599

merged 1 commit into from
Sep 5, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Sep 4, 2023

Resolves #1596

@pinosu pinosu requested a review from alpe as a code owner September 4, 2023 15:02
@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #1599 (ffcfa8d) into main (0371b65) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
- Coverage   58.22%   58.20%   -0.03%     
==========================================
  Files          64       64              
  Lines        8642     8642              
==========================================
- Hits         5032     5030       -2     
- Misses       3197     3198       +1     
- Partials      413      414       +1
Files Changed Coverage Δ
x/wasm/types/wasmer_engine.go 0.00% <ø> (ø)
x/wasm/keeper/keeper.go 87.05% <100.00%> (-0.31%) ⬇️
x/wasm/keeper/options.go 81.81% <100.00%> (ø)

alpe
alpe approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very nice. Good balance to keep references to wasmer where it still makes sense

@alpe alpe merged commit 1149653 into main Sep 5, 2023
8 checks passed
@alpe alpe deleted the 1596-remove_wasmer_ref branch September 5, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all references to "Wasmer"
2 participants
@pinosu @alpe