Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to "Wasmer" #1596

Closed
webmaster128 opened this issue Sep 4, 2023 · 0 comments · Fixed by #1599
Closed

Remove all references to "Wasmer" #1596

webmaster128 opened this issue Sep 4, 2023 · 0 comments · Fixed by #1599
Assignees
Milestone

Comments

@webmaster128
Copy link
Member

In the codebase there are a lot of references to Wasmer. I assume for historic reasons. Wasmer is the engine used by cosmwasm-vm/wasmvm to execute WebAssembly. However, this is an implementation detail and nothing wasmd should worry about. A different engine could be used any time or even multiple could be used in differen circumstances.

To avoid confusion and improve overall code quality, pretty much all references to Wasmer should be removed from here. In a quick search I found those, but the list is probably not complete:

  • WasmerEngine interface
  • MockWasmer
  • NewIBCContractMockWasmer
  • "wasmer gas" should be "CosmWasm gas"
  • "Wasmer function execution"

A full text search in the codebase should find them all.

@alpe alpe added this to the v0.42.0 milestone Sep 4, 2023
@pinosu pinosu self-assigned this Sep 4, 2023
@alpe alpe closed this as completed in #1599 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants