Expose GET partyinfo API on ThirdParty server #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namtruong
requested review from
chris-j-h,
melowe,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
============================================
+ Coverage 99.35% 99.36% +<.01%
- Complexity 2094 2097 +3
============================================
Files 318 319 +1
Lines 5772 5792 +20
Branches 310 310
============================================
+ Hits 5735 5755 +20
Misses 5 5
Partials 32 32
Continue to review full report at Codecov.
|
...ra-jaxrs/thirdparty-jaxrs/src/main/java/com/quorum/tessera/thirdparty/PartyInfoResource.java
Outdated
Show resolved
Hide resolved
nicolae-leonte-go
approved these changes
Nov 11, 2019
chris-j-h
reviewed
Nov 11, 2019
...ra-jaxrs/thirdparty-jaxrs/src/main/java/com/quorum/tessera/thirdparty/PartyInfoResource.java
Show resolved
Hide resolved
chris-j-h
reviewed
Nov 11, 2019
...ra-jaxrs/thirdparty-jaxrs/src/main/java/com/quorum/tessera/thirdparty/PartyInfoResource.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables peer/party network info of the node to be retrievable on ThirdParty server. The result now only contains list of public keys - data such as lastContact, url, etc... have been removed.
The same API on P2P server is still being kept just for testing purpose - however, this can potentially be deprecated at some point in the future. Coupled with #917, this api will no longer be accessible from a browser.