Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Private From field #14

Closed
trung opened this issue Nov 12, 2019 · 3 comments
Closed

Support Private From field #14

trung opened this issue Nov 12, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@trung
Copy link

trung commented Nov 12, 2019

Private From indicates the public key of the sender Tessera. By default Tessera will take the first key in its config. However, Tessera can manage multiple keys.

User should be able to select keys from the connected Tessera for Private From field

@bmcd
Copy link
Contributor

bmcd commented Nov 13, 2019

Once we have an endpoint on the 3rd party server that gives us those keys we can add this feature

@bmcd bmcd added the enhancement New feature or request label Nov 13, 2019
@trung
Copy link
Author

trung commented Nov 13, 2019

Indeed, /partyinfo provides url which can be used to filter keys belonging to the Tessera node.
E.g.: In the below party info JSON, url is http://172.16.239.101:9000/ and this value is used to filter only keys matching with the value

{
  "url": "http://172.16.239.101:9000/",
  "peers": [
    {
      "url": "http://172.16.239.102:9000/",
      "lastContact": "2019-11-13T19:18:16.712Z"
    },
    {
      "url": "http://172.16.239.101:9000/",
      "lastContact": "2019-11-13T19:18:18.191Z"
    },
    {
      "url": "http://172.16.239.103:9000/",
      "lastContact": "2019-11-13T19:18:18.106Z"
    }
  ],
  "keys": [
    {
      "key": "T/XI88Mve2Xacso1wRwb38oMVkRe0Lv6N9sh27Ra/CI=",
      "url": "http://172.16.239.102:9000/"
    },
    {
      "key": "6eutyLl6MiuB2OePngk8FpEas3SYvbdSoSLDC7fUmAM=",
      "url": "http://172.16.239.101:9000/"
    },
    {
      "key": "Zw/4lsanZrRFY66auRrxjvDSxr7Rs+k0zBnFNL/DG1A=",
      "url": "http://172.16.239.101:9000/"
    },
    {
      "key": "OtiLC2xcGE/biywtRKbKcU5IcVMFI2HARPtTwwpph3o=",
      "url": "http://172.16.239.101:9000/"
    },
    {
      "key": "/1hWFJkOsPor8hUvaj6iQ14lck5+HvyHyxzAoUs2ITs=",
      "url": "http://172.16.239.101:9000/"
    },
    {
      "key": "6yV8kcLrlBZScHbXE8qltuHtQ0MJjToCm0KUnsEp1AM=",
      "url": "http://172.16.239.102:9000/"
    },
    {
      "key": "AdgDRwPyhshYc0jwaSLpIAj4nQ8+herBFntIv/+QExw=",
      "url": "http://172.16.239.103:9000/"
    }
  ]
}

@bmcd
Copy link
Contributor

bmcd commented Nov 13, 2019

Consensys/tessera#917 Consensys/tessera#918 Consensys/tessera#920

^^^ Those make this not really possible anymore. The P2P apis shouldn't really be open to the world, and they are disabling CORS altogether for P2P.

They are adding /partyinfo/keys to 3rdParty, but it no longer includes urls. They will be adding a new endpoint for the current keys in the tessera node soon (or maybe just adding it to that response, i don't know). Once they add that we should be able to do privateFrom properly.

@bmcd bmcd closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants