-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7013 add types #7146
Merged
StefanBratanov
merged 10 commits into
Consensys:master
from
mehdi-aouadi:7013-add-types
May 17, 2023
Merged
7013 add types #7146
StefanBratanov
merged 10 commits into
Consensys:master
from
mehdi-aouadi:7013-add-types
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS: This PR is rebased on #7145 |
mehdi-aouadi
force-pushed
the
7013-add-types
branch
from
May 16, 2023 07:44
1b405cb
to
f0980ed
Compare
rolfyone
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/BeaconBlockBody.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/BeaconBlockHeader.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/Checkpoint.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/Deposit.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/DepositData.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/Eth1Data.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/IndexedAttestation.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/KZGCommitment.java
Outdated
Show resolved
Hide resolved
mehdi-aouadi
force-pushed
the
7013-add-types
branch
from
May 16, 2023 12:17
f0980ed
to
57ef3d0
Compare
mehdi-aouadi
force-pushed
the
7013-add-types
branch
from
May 16, 2023 14:49
502a5cc
to
d7a4b06
Compare
mehdi-aouadi
force-pushed
the
7013-add-types
branch
from
May 16, 2023 14:51
d7a4b06
to
aabd7c6
Compare
@rolfyone Cleaned as discussed. Looks way better now thanks! |
2 tasks
rolfyone
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add signed block and signed block contents deserialisation types
Spec reference here
Fixed Issue(s)
#7013
Documentation
doc-change-required
label to this PR if updates are required.Changelog