Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7013 add types #7146

Merged
merged 10 commits into from
May 17, 2023
Merged

7013 add types #7146

merged 10 commits into from
May 17, 2023

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented May 15, 2023

PR Description

Add signed block and signed block contents deserialisation types

Spec reference here

Fixed Issue(s)

#7013

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi self-assigned this May 15, 2023
@mehdi-aouadi mehdi-aouadi added the Epic Deneb Issues required to implement Deneb upgrade label May 15, 2023
@mehdi-aouadi
Copy link
Contributor Author

PS: This PR is rebased on #7145

@mehdi-aouadi mehdi-aouadi marked this pull request as ready for review May 16, 2023 15:12
@mehdi-aouadi
Copy link
Contributor Author

@rolfyone Cleaned as discussed. Looks way better now thanks!

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) May 17, 2023 07:38
@StefanBratanov StefanBratanov merged commit 99107ce into Consensys:master May 17, 2023
@mehdi-aouadi mehdi-aouadi deleted the 7013-add-types branch July 26, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants