7013 add blinded blocks block contents type #7150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is rebased on #7146 |
rolfyone
reviewed
May 17, 2023
Comment on lines
57
to
60
| SignedBlobSidecarSchema.create( | ||
| BlobSidecarSchema.create( | ||
| new BlobSchema( | ||
| spec.getGenesisSpecConfig().toVersionDeneb().orElseThrow()))), |
There was a problem hiding this comment.
Basically this, it's just generally not fully exposed here...
if you look at GetLightClientBootstrap as an example, but basically you'd be doing the .create elsewhere, and here it'd be something like
SchemaDefinitionsDeneb.required(
schemaDefinitionCache.getSchemaDefinition(SpecMilestone.DENEB))
.getSignedBlockContentsSchema()
.getJsonTypeDefinition()
There was a problem hiding this comment.
admittedly arugable either way in an actual test, but in the endpoints it'd look like this...
rolfyone
reviewed
May 17, 2023
Comment on lines
79
to
73
| SignedBlindedBlockContentsSchema.create( | ||
| spec.getGenesisSpecConfig().toVersionDeneb().orElseThrow(), | ||
| SignedBlindedBlobSidecarSchema.create(BlindedBlobSidecarSchema.create()), | ||
| spec.getGenesisSchemaDefinitions().getSignedBeaconBlockSchema()) | ||
| .getJsonTypeDefinition()) |
There was a problem hiding this comment.
SchemaDefinitionsDeneb.required(
schemaDefinitionCache.getSchemaDefinition(SpecMilestone.DENEB))
.getSignedBlindedBlockContentsSchema()
.getJsonTypeDefinition()
ish..
StefanBratanov
force-pushed
the
7013-add-blinded-blocks-blockcontents-type
branch
from
2c2c6f4
to
8aabca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add blinded block and blinded block contents deseriliasation types
Spec reference here
Fixed Issue(s)
#7013
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog