Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update state manager documentation #707
Update state manager documentation #707
Changes from all commits
4b6812f
ddbf688
75b9378
bba114e
c1170cf
ad73577
61cb33a
cdd077d
6b60d15
cd121d5
31a8930
16e7783
0970157
a6c7f5c
e8c0962
5d93934
a11b3a7
412f727
6b5ae2e
92ab80c
a0dd220
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this go through SME review? I am still confused by the CRUD statement here. Thought I added comment on this before.
My (probably naive) takeaway from A's doc is that the ability to overwrite the 0 is a feature required by the proof generator --> I don't think this update extends to storing state. I would recommend having SME review this as any mention of UD (especially the delete) must be made clear --> the immutable nature of blockchain (as in the typical use of PMT) allows for old data to be ignored thanks to availability of more recent data/updated state, this is NOT the same as a typical database's CRUD behaviour. FAO @jlwllmr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m4sterbunny thank you — as discussed, following up with SME on this issue 🫡