Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state manager documentation #707

Merged
merged 21 commits into from
Sep 17, 2024
Merged

Update state manager documentation #707

merged 21 commits into from
Sep 17, 2024

Conversation

jlwllmr
Copy link
Collaborator

@jlwllmr jlwllmr commented Aug 28, 2024

Overhauls state management page in the architecture section, adding considerably more detail about Linea's use of sparse Merkle trees and the accumulator structure.

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 4:00pm

Copy link
Collaborator

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback

docs/architecture/stack/evm-state-manager/index.mdx Outdated Show resolved Hide resolved
docs/architecture/stack/evm-state-manager/index.mdx Outdated Show resolved Hide resolved
docs/architecture/stack/evm-state-manager/index.mdx Outdated Show resolved Hide resolved
docs/architecture/stack/evm-state-manager/index.mdx Outdated Show resolved Hide resolved
docs/architecture/stack/evm-state-manager/index.mdx Outdated Show resolved Hide resolved
docs/architecture/stack/evm-state-manager/index.mdx Outdated Show resolved Hide resolved
docs/architecture/stack/evm-state-manager/index.mdx Outdated Show resolved Hide resolved
docs/architecture/stack/evm-state-manager/index.mdx Outdated Show resolved Hide resolved
@jlwllmr jlwllmr added the enhancement New feature or request label Sep 6, 2024
@jlwllmr jlwllmr merged commit d6f348d into main Sep 17, 2024
9 checks passed
@jlwllmr jlwllmr deleted the state-management branch September 17, 2024 08:21
capabilities.

Linea's state manager uses an extended version of a sparse Merkle tree that enables it to prove all
CRUD (create, read, update, delete) operations for a key-addressed database. As an outline, the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this go through SME review? I am still confused by the CRUD statement here. Thought I added comment on this before.
My (probably naive) takeaway from A's doc is that the ability to overwrite the 0 is a feature required by the proof generator --> I don't think this update extends to storing state. I would recommend having SME review this as any mention of UD (especially the delete) must be made clear --> the immutable nature of blockchain (as in the typical use of PMT) allows for old data to be ignored thanks to availability of more recent data/updated state, this is NOT the same as a typical database's CRUD behaviour. FAO @jlwllmr

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m4sterbunny thank you — as discussed, following up with SME on this issue 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants