Use own registry for the stats handler #1837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovromazgon
reviewed
Sep 10, 2024
Comment on lines
+254
to
+255
| promclient.MustRegister(reg) | ||
| reg.MustRegister(h) |
There was a problem hiding this comment.
This only masks the issue, turning these two lines around produces the same panic.
I'm thinking we could continue using the default registry and only register metrics if they are not yet registered.
|
Closing, superseded by #1842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use own registry for the stats handler to create separation between the global/default prom client registry.
Conduit metrics are already using a separate registry.
When testing Conduit embedded,
..MustRegister()may fail due to the stats handler already registered in the global registry.Quick checks