Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register prometheus metrics only once #1842

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Register prometheus metrics only once #1842

merged 4 commits into from
Sep 10, 2024

Conversation

lovromazgon
Copy link
Member

Description

This makes sure that creating the runtime twice doesn't panic, by registering metrics only once.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner September 10, 2024 16:35
@lyuboxa lyuboxa mentioned this pull request Sep 10, 2024
Closed
4 tasks
@lyuboxa lyuboxa merged commit fe22032 into main Sep 10, 2024
3 checks passed
@lyuboxa lyuboxa deleted the lovro/prom-registry branch September 10, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyuboxa lyuboxa lyuboxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovromazgon @lyuboxa