[Perf] Inspector refactoring and optimization #1248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The inspector was allocating quite a lot of data even if no sessions were open. Now it's optimized for the hot path when there are no open sessions.
Note that the single session benchmark is slower now because of the use of
Record.Clone()
, although that usage is now correct, since we previously did not clone all fields. Note that cloning of records was sped up in #1247.Quick checks: