Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Clone record without reflection #1247

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[Perf] Clone record without reflection #1247

merged 2 commits into from
Oct 24, 2023

Conversation

lovromazgon
Copy link
Member

Description

This PR optimizes record cloning in Conduit so it does not use reflection.

Fixes #885

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests. (existing tests)
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner October 20, 2023 19:17
@lovromazgon lovromazgon mentioned this pull request Oct 20, 2023
Merged
4 tasks
@lovromazgon lovromazgon merged commit bbdb074 into main Oct 24, 2023
3 checks passed
@lovromazgon lovromazgon deleted the lovro/clone-record branch October 24, 2023 11:18
@simonl2002 simonl2002 modified the milestones: 0.9.0, 0.8.0 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nassor nassor nassor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Conduit Main
Archived in project
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Optimize record cloning
3 participants
@lovromazgon @nassor @simonl2002