Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR: Processor encodewithschema #1098

Merged
merged 3 commits into from
Jul 14, 2023
Merged

SR: Processor encodewithschema #1098

merged 3 commits into from
Jul 14, 2023

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Jun 30, 2023

Description

⚠️ This PR is based on top of #1097.

This PR adds a processor encodewithschema as described here.

Fixes #1044

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests. (if I get the time I'll add some later, did manually test though)
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner June 30, 2023 17:10
@lovromazgon lovromazgon force-pushed the lovro/sr-decodewithschema branch from 051466b to daad555 Compare July 13, 2023 14:18
@lovromazgon lovromazgon force-pushed the lovro/sr-encodewithschema branch from 6d06eb6 to 0191cc3 Compare July 13, 2023 14:20
@lovromazgon lovromazgon mentioned this pull request Jul 13, 2023
4 tasks
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@lovromazgon lovromazgon force-pushed the lovro/sr-decodewithschema branch from daad555 to 4cd70ed Compare July 14, 2023 13:12
Base automatically changed from lovro/sr-decodewithschema to main July 14, 2023 13:15
@lovromazgon lovromazgon force-pushed the lovro/sr-encodewithschema branch from 9feb194 to e88248e Compare July 14, 2023 13:18
@lovromazgon lovromazgon merged commit 00b362f into main Jul 14, 2023
@lovromazgon lovromazgon deleted the lovro/sr-encodewithschema branch July 14, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SR: Create Processors for Encoding with Schema
3 participants