Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SR: Processor decodewithschema #1097

Merged
merged 1 commit into from
Jul 14, 2023
Merged

SR: Processor decodewithschema #1097

merged 1 commit into from
Jul 14, 2023

Conversation

lovromazgon
Copy link
Member

Description

⚠️ This PR is based on top of #1096.

This PR adds a processor decodewithschema as described here.

Fixes #1045

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests. (if I get the time I'll add some later, did manually test though)
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner June 30, 2023 17:10
@lovromazgon lovromazgon changed the base branch from main to lovro/sr-encoder-decoder June 30, 2023 17:10
@lovromazgon lovromazgon mentioned this pull request Jun 30, 2023
Merged
4 tasks
@lovromazgon lovromazgon force-pushed the lovro/sr-encoder-decoder branch from 43feb98 to 71b30fe Compare July 13, 2023 14:17
@lovromazgon lovromazgon force-pushed the lovro/sr-decodewithschema branch from 051466b to daad555 Compare July 13, 2023 14:18
@lovromazgon
Copy link
Member Author

Note that I added documentation for the processor in #1098.

hariso
hariso approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! At some point, it would be good if we add some tests. I understand right now it may not be feasible.

Base automatically changed from lovro/sr-encoder-decoder to main July 14, 2023 13:09
@lovromazgon lovromazgon force-pushed the lovro/sr-decodewithschema branch from daad555 to 4cd70ed Compare July 14, 2023 13:12
@lovromazgon lovromazgon enabled auto-merge (squash) July 14, 2023 13:13
@lovromazgon lovromazgon merged commit 13221ad into main Jul 14, 2023
@lovromazgon lovromazgon deleted the lovro/sr-decodewithschema branch July 14, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SR: Create Processors for Decoding with Schema
2 participants
@lovromazgon @hariso