Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude melee from wall frags #3572

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Conversation

Safairette
Copy link
Contributor

Changes

  • Melee attacks now no longer create fragments when the fragments from walls are enabled

Reasoning

  • Using melee to break buildings/debris carries disproportionate risk with the setting enabled.
  • Melee attacks should be the only instances of damage where the tool isn't null, so shouldn't affect anything else.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Gunshots still make the wall ouchies
  • Playtested a colony (specify how long)

@Safairette Safairette requested review from a team as code owners November 28, 2024 11:23
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12067939797.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 28, 2024
MaxDorob
MaxDorob previously approved these changes Nov 29, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing to prevent the issue; still getting fragments spawning attacking walls with longsword, zeushammer, mace, and bare fists.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12095461249.zip

@N7Huntsman N7Huntsman merged commit d40786c into Development Nov 30, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the melee-wallfrags-exclusion branch November 30, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants