Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix high-shields not intercepting indirect fire shells #3515

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mszabo-wikia
Copy link
Contributor

Changes

#2869 adjusted the collision check used by shields to normalize away the 3D component of positions by default, which in turn caused high-shields to no longer intercept indirect fire shells. Switch these to use spherical collision checking to bring back the old behavior.

References

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony -- spawned in a mech cluster with a high-shield, and verified that regular mortar shells now explode upon contact with the shield without dealing damage while EMP shields still break the shield

@mszabo-wikia mszabo-wikia requested review from a team as code owners October 27, 2024 20:26
@mszabo-wikia
Copy link
Contributor Author

Test save:
mortar.rws.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11543568159.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 27, 2024
N7Huntsman
N7Huntsman previously approved these changes Oct 28, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue with high shields not intercepting mortars. Though, when they explode, the blasts still appear at ground level, due to how RW handles the explosions. Players could find this somewhat misleading--though I'm not sure what exactly could be done about it.

I've notice that mortar shell shadows now follow and odd-looking parabolic arc (without the shell rotating to "fly" normally), but that's not directly related to this PR.

Copy link
Contributor

@MaxDorob MaxDorob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

#2869 adjusted the collision check
used by shields to normalize away the 3D component of positions by default, which in turn
caused high-shields to no longer intercept indirect fire shells. Switch these to use spherical
collision checking to bring back the old behavior.
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11981309583.zip

@N7Huntsman N7Huntsman merged commit c525268 into Development Nov 26, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the high-shield-fix branch November 26, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mech high-shield does not intercept mortar rounds
4 participants