-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix high-shields not intercepting indirect fire shells #3515
Conversation
Test save: |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11543568159.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the issue with high shields not intercepting mortars. Though, when they explode, the blasts still appear at ground level, due to how RW handles the explosions. Players could find this somewhat misleading--though I'm not sure what exactly could be done about it.
I've notice that mortar shell shadows now follow and odd-looking parabolic arc (without the shell rotating to "fly" normally), but that's not directly related to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
#2869 adjusted the collision check used by shields to normalize away the 3D component of positions by default, which in turn caused high-shields to no longer intercept indirect fire shells. Switch these to use spherical collision checking to bring back the old behavior.
e75881e
to
fe7b517
Compare
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11981309583.zip |
Changes
#2869 adjusted the collision check used by shields to normalize away the 3D component of positions by default, which in turn caused high-shields to no longer intercept indirect fire shells. Switch these to use spherical collision checking to bring back the old behavior.
References
Testing
Check tests you have performed: