Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanila framework expanded based shields fix #2869

Merged
merged 26 commits into from
Nov 14, 2023
Merged

Conversation

MaxDorob
Copy link
Contributor

@MaxDorob MaxDorob commented Nov 2, 2023

Based on #2856

Changes

Fixed CompShieldField-based shields (e.g.: RM2 (caretaker broken now ) or VFE - Archon)

  • Fixes stacked in air projeciles
image
  • Fixed shield as apparel
  • Optimized.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (tested caretaker shield (there's a non-CE related error because VFE was updated but RM2 was not) and archon shield)

@MaxDorob MaxDorob requested review from a team as code owners November 2, 2023 12:13
Copy link

github-actions bot commented Nov 2, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739463071.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739505288.zip

Copy link

github-actions bot commented Nov 2, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739515973.zip

Copy link

github-actions bot commented Nov 3, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739658618.zip

Copy link

github-actions bot commented Nov 3, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739752235.zip

Copy link

github-actions bot commented Nov 4, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6756747555.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in testing, no issues.

@perkinslr perkinslr merged commit 87c118f into Development Nov 14, 2023
2 checks passed
@perkinslr perkinslr deleted the VFE_Shields_Fix branch November 14, 2023 00:52
mszabo-wikia added a commit that referenced this pull request Oct 27, 2024
#2869 adjusted the collision check
used by shields to normalize away the 3D component of positions by default, which in turn
caused high-shields to no longer intercept indirect fire shells. Switch these to use spherical
collision checking to bring back the old behavior.
mszabo-wikia added a commit that referenced this pull request Nov 22, 2024
#2869 adjusted the collision check
used by shields to normalize away the 3D component of positions by default, which in turn
caused high-shields to no longer intercept indirect fire shells. Switch these to use spherical
collision checking to bring back the old behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants