-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanila framework expanded based shields fix #2869
Conversation
…l collision checks (can help to avoid early interception)
Debug statements
Fixed stucked in air projectiles Optimized
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739463071.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739505288.zip |
333f9b4
to
16e58fc
Compare
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739515973.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739658618.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6739752235.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6756747555.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in testing, no issues.
#2869 adjusted the collision check used by shields to normalize away the 3D component of positions by default, which in turn caused high-shields to no longer intercept indirect fire shells. Switch these to use spherical collision checking to bring back the old behavior.
#2869 adjusted the collision check used by shields to normalize away the 3D component of positions by default, which in turn caused high-shields to no longer intercept indirect fire shells. Switch these to use spherical collision checking to bring back the old behavior.
Based on #2856
Changes
Fixed CompShieldField-based shields (e.g.: RM2 (caretaker broken now ) or VFE - Archon)
Testing
Check tests you have performed: