Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync zzz-mobile-mode with main #604

Merged
merged 586 commits into from
Nov 15, 2024

Update to .NET 9 GA

73db88d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

sync zzz-mobile-mode with main #604

Update to .NET 9 GA
73db88d
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana for .NET completed Nov 13, 2024 in 0s

1945 new problems found by Qodana for .NET

Qodana for .NET

1945 new problems were found

Inspection name Severity Problems
XAML Errors 🔴 Failure 4
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 1314
Possible 'System.NullReferenceException' 🔶 Warning 81
Possible 'null' assignment to non-nullable entity 🔶 Warning 44
Invalid XML documentation comment 🔶 Warning 33
Assignment is not used 🔶 Warning 32
Redundant using directive 🔶 Warning 31
Virtual member call in constructor 🔶 Warning 26
Redundant cast 🔶 Warning 25
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 21
Conditional access qualifier expression is known to be null or not null 🔶 Warning 17
Redundant catch clause 🔶 Warning 15
Unused local variable 🔶 Warning 13
Remove redundant attached property setter 🔶 Warning 13
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 12
Redundant control flow jump statement 🔶 Warning 12
RoslynAnalyzers Project does not enable unsafe blocks 🔶 Warning 11
Missing grid column/row setter for non-first child 🔶 Warning 11
Access to modified captured variable 🔶 Warning 10
Method return value is never used (private accessibility) 🔶 Warning 10
Property value is equal to style-provided 🔶 Warning 10
Underlying type of enum is 'int' 🔶 Warning 9
Non-readonly type member referenced in 'GetHashCode()' 🔶 Warning 9
Redundant base constructor call 🔶 Warning 9
Non-accessed field (private accessibility) 🔶 Warning 8
Unassigned field 🔶 Warning 8
Incorrect indent (around child statement) 🔶 Warning 7
'??' condition is known to be null or not null 🔶 Warning 7
Non-accessed local variable 🔶 Warning 7
Member initialized value ignored 🔶 Warning 6
Parameter hides member 🔶 Warning 6
Redundant lambda expression parameter type specification 🔶 Warning 6
Avoid mixing of variable-length escape sequences and text 🔶 Warning 6
Bitwise operation on enum that is not marked by the [Flags] attribute 🔶 Warning 5
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. 🔶 Warning 5
Possible overflow in unchecked context 🔶 Warning 5
Auto-property accessor is never used (private accessibility) 🔶 Warning 5
Unused nullable directive 🔶 Warning 5
Collection content is never queried (non-private accessibility) 🔶 Warning 4
Collection is never updated (non-private accessibility) 🔶 Warning 4
Expression is always 'true' or always 'false' 🔶 Warning 4
Empty general catch clause 🔶 Warning 4
Cannot resolve symbol in text argument 🔶 Warning 4
Unsafe context declaration is redundant 🔶 Warning 4
Variable can be declared as non-nullable 🔶 Warning 4
Async method invocation without await expression 🔶 Warning 3
Inconsistent synchronization on field 🔶 Warning 3
Local variable hides member 🔶 Warning 3
Mismatch of optional parameter value in overridden method 🔶 Warning 3
Redundant 'base.' qualifier 🔶 Warning 3
Actual shift count equals zero 🔶 Warning 3
Variable in local function hides variable from outer scope 🔶 Warning 3
Grid element column/row index is out of grid definition range 🔶 Warning 3
Collection content is never queried (private accessibility) 🔶 Warning 2
'?:' expression has identical true and false branches 🔶 Warning 2
Non-accessed field 🔶 Warning 2
Possible unassigned object created by 'new' expression 🔶 Warning 2
Explicit delegate creation expression is redundant 🔶 Warning 2
Redundant 'IEnumerable.Cast<T>' or 'IEnumerable.OfType<T>' call 🔶 Warning 2
Do not use object initializer for 'using' variable 🔶 Warning 2
Path error 🔶 Warning 2
Possible null reference return. 🔶 Warning 1
Co-variant array conversion 🔶 Warning 1
Struct with default equality members is used for comparison (non-private accessibility) 🔶 Warning 1
Empty constructor 🔶 Warning 1
Heuristically unreachable code 🔶 Warning 1
Parameter output value is always discarded (private accessibility) 🔶 Warning 1
Redundant 'partial' modifier on method declaration 🔶 Warning 1
Possible 'System.InvalidCastException' in foreach loop 🔶 Warning 1
Possible 'System.InvalidOperationException' 🔶 Warning 1
Possible loss of fraction 🔶 Warning 1
Redundant nullable attribute 🔶 Warning 1
Redundant nullable warning suppression expression 🔶 Warning 1
Redundant 'object.ToString()' call 🔶 Warning 1
Redundant type arguments of method 🔶 Warning 1
Return value of pure method is not used 🔶 Warning 1
String.IndexOf is culture-specific (string.IndexOf(string) is culture-specific) 🔶 Warning 1
String.LastIndexOf is culture-specific (string.LastIndexOf(string) is culture-specific) 🔶 Warning 1
Usage of default struct equality 🔶 Warning 1
Redundant namespace alias 🔶 Warning 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 547 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 558 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 560 in Hi3Helper.Sophon/SophonAsset.Download.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 434 in Hi3Helper.Sophon/SophonAsset.Diff.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 546 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 424 in Hi3Helper.Sophon/SophonAsset.Diff.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 550 in Hi3Helper.Sophon/SophonAsset.Download.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 566 in Hi3Helper.Sophon/SophonAsset.Download.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 440 in Hi3Helper.Sophon/SophonAsset.Diff.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 548 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 122 in CollapseLauncher/Classes/ShortcutCreator/SteamShortcut.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 232 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/InstallationConvert.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 360 in CollapseLauncher/Classes/RepairManagement/StarRail/Check.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 53 in SevenZipExtractor/SevenZipExtractor/SevenZipHandle.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 446 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 79 in CollapseLauncher/Classes/RegistryMonitor/RegistryMonitor.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 132 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 50 in Hi3Helper.EncTool/Parser/SRMetadata/SRMetadataReader/SRMetadataBase.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 429 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 400 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 443 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 259 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/InstallationConvert.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 220 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 128 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 95 in Hi3Helper.EncTool/Parser/Proto/src/StarRailDispatchStatic.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity
View more details on GitHub Actions