"Add to Steam" and creation of shortcuts #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated activation event from Could be useful for future use. For example, future CMD arguments that need redirection but are not related to the mainPage.
Images are either official art or from SteamGridDB. For testing, should be reviewed and/or changed after.
CollapseLauncher-ReleaseRepo/#12
bagusnl
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
No code issue other than we have discussed before.
Requesting recheck by @neon-nyan due to COM interaction and encodings that is beyond my knowledge
gablm
commented
Jan 21, 2024
neon-nyan
approved these changes
Jan 27, 2024
|
Approbal achieved @gablm can you check on the merge conflicts? We can merge it once the conflicts are resolved |
|
There doesn't seem to be any merge conflicts on my end |
|
I was looking at the wrong merge type, rebase causes conflict but squash and commit doesn't :derp: Alrighty, merging by squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Additions
1. Shortcut Creation
Asks for a folder and creates a .url file linking to Collapses' URL Protocol.
"-p" is be added if selected in the UI.
2. Addition of regions to Steam
Parses and writes a new shortcuts.vdf including a new shortcut for the region for every folder in Steam's userdata folder.
Also downloads the assets related to this shortcut.
If the shortcut already exists, it will be removed and added again while also checking if the md5 checksum for all assets matches and if any file needs to be downloaded.
Requirements
closes #358