Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.ini issue (Parsing issue happen again) #12

Closed
KorewaLidesu opened this issue Jul 3, 2022 · 11 comments
Closed

config.ini issue (Parsing issue happen again) #12

KorewaLidesu opened this issue Jul 3, 2022 · 11 comments
Labels
Area: Preset Config Issue labeled for Preset/Region Configuration Bug Something isn't working Fixed Issue has been fixed

Comments

@KorewaLidesu
Copy link

KorewaLidesu commented Jul 3, 2022 •
edited
Loading

No log avail, here is config.ini
I have talking about this issue before on DIscord (Korewa_Li#0001)

channel=1
cps=
game_version=5.8.0
sub_channel=1
sdk_version=

older/Hi3SEA
game_start_name=BH3.exe
is_first_exit=False
exit_type=2

=2```
@KorewaLidesu
Copy link
Author

KorewaLidesu commented Jul 3, 2022 •
edited
Loading

Also, about Install/Update function, can you try optional for requirement of compressed game file?
As it is require me to download them to allow me launch game from launcher (if it is imposssible please ignore this comment)

@neon-nyan
Copy link
Member

neon-nyan commented Jul 7, 2022 •
edited
Loading

Hi There,
Sorry for my late reply for this as I'm kind of busy on my RL job this week.
Yes, the bug on INI Parser is still happening and I'm planning to move to this project or using build-in Win32 INI Parser via Interop

Also, for the second question, Sorry if I'm not quite understand but did you mean the feature that allows you to use existing game installation?

@neon-nyan neon-nyan added the Bug Something isn't working label Jul 7, 2022
@KorewaLidesu
Copy link
Author

KorewaLidesu commented Jul 7, 2022 •
edited
Loading

Hi There, Sorry for my late reply for this as I'm kind of busy on my RL job this week. Yes, the bug on INI Parser is still happening and I'm planning to move to this project or using build-in Win32 INI Parser via Interop

Also, for the second question, Sorry if I'm not quite understand but did you mean the feature that allows you to use existing game installation?

Sorry if what I said is kinda ish to understand
Me feel same tho image
I mean when I try use existing game installation, the launcher does pick up it. But after that, it required me to download archived game file (BH3_v5.8.0_01a63f16c96d.7z) which is annoying me even if I can launch the game directly using BH3.exe
I would like a option that allow me to skip file that missing in game folder.

@neon-nyan
Copy link
Member

Uhm, that's weird. The launcher should still using the existing game installation and shouldn't redownload the entire thing again.
Could you check if the config.ini file inside of the App Data folder is also getting broken? (the one you can open by going to "App Settings" > "Open App Data Folder")

@KorewaLidesu
Copy link
Author

KorewaLidesu commented Jul 8, 2022 •
edited
Loading 

channel=1
cps=
game_version=5.8.0
sub_channel=1
sdk_version=
game_install_path=D:\GAME\CollapseFolder\Hi3SEA
game_start_name=BH3.exe
is_first_exit=False
exit_type=2

I use the similar one that you suggest on Discord. Maybe something on my side instead tho :teri_worry:

@neon-nyan
Copy link
Member

Uhm, config file doesn't seem to have an issue.
Can you try to locate the installation location to the existing installation once you're getting asked by the launcher to install the game?
You can click on Install Game > Then click "Locate Location" and choose the location where the BH3.exe should be located

@KorewaLidesu
Copy link
Author

Uhm, config file doesn't seem to have an issue. Can you try to locate the installation location to the existing installation once you're getting asked by the launcher to install the game? You can click on Install Game > Then click "Locate Location" and choose the location where the BH3.exe should be located

Yes, have done it before. Still give required an update.
P/s: Use Delta patch actually skip the requirement for update, but after config.ini issue occur, it is required too update again.

sorry if it is hard for you to understand, me just poor english :teri_cry:

@neon-nyan
Copy link
Member

neon-nyan commented Jul 9, 2022 •
edited
Loading

That's surely weird.

Anyway, Hope I can investigate about this further and anyway, what version and which release channel (stable/preview) you're using right now?

@KorewaLidesu
Copy link
Author

KorewaLidesu commented Jul 9, 2022 via email

@neon-nyan
Copy link
Member

Okay, thanks for the info. I will leave this issue open and hope I can fix this in the next version

neon-nyan added a commit that referenced this issue Jul 10, 2022
@neon-nyan
Fix potential broken INI Structure while saving
860862f 
Also Simplify some methods and remove IEnumerable<T> since it's no longer used
This commit is focused on fix for Issue No: #12
@neon-nyan
Copy link
Member

neon-nyan commented Jul 11, 2022 •
edited
Loading

Hi there,
This INI Parsing issue has been addressed in 1.0.33.2 release.

If you don't have any question for this, I think we can close this issue.
Also, thank you for reporting this. Hope this launcher could improve over time.

@neon-nyan neon-nyan added the Fixed Issue has been fixed label Jul 11, 2022
@neon-nyan neon-nyan added the Area: Preset Config Issue labeled for Preset/Region Configuration label Oct 17, 2022
bagusnl pushed a commit that referenced this issue Jan 27, 2024
@gablm
"Add to Steam" and creation of shortcuts (#378)
3f8c4a3 
#### 1. Shortcut Creation
Asks for a folder and creates a .url file linking to Collapses' URL Protocol. 
"-p" is be added if selected in the UI. 

#### 2. Addition of regions to Steam
Parses and writes a new shortcuts.vdf including a new shortcut for the region for every folder in Steam's userdata folder.
Also downloads the assets related to this shortcut.
If the shortcut already exists, it will be removed and added again while also checking if the md5 checksum for all assets matches and if any file needs to be downloaded.

### Requirements 
 - CollapseLauncher/CollapseLauncher-ReleaseRepo#12
   - Adds the Assets needed to the metadata
 - System.Text.Encoding.CodePages
   - Adds ANSI encoding
--------------------------

* Add parsing for a play option

* launching arguments for regions

* No redirection way

* Handle redirection

* Update MainPage.xaml.cs

* Change the check for starting the game

* Fix out of bounds exception

* Separate activation handling from mainPage

Separated activation event from
Could be useful for future use.
For example, future CMD arguments that need redirection but are not related to the mainPage.

* Remove unused "using" statements && partial keyword

* Fix arguments not being cleared before parsing them on activation

* Alterations based on code review + Fix parsing of arguments between quotes

* Help message changes

* Basic UI

* Add icons + new class

* Start of steam support

* Shortcut struct

* Update ShortcutCreator.cs

* Why does valve need a proprietary data format :sku

* Update ShortcutCreator.cs

* The parser is real!

* Update ShortcutCreator.cs

* It works now

* Actually fully works now

* Add to steam

* Steam id generation

* Update ShortcutCreator.cs

* Add Game Logos

* Add other ids

* Shortcut assets + fix appid generation

Images are either official art or from SteamGridDB.
For testing, should be reviewed and/or changed after.

* Add banners to the shortcut creation

* Change usage of GamePresetProperty to PresetConfigV2

* Separate code into two classes

* Desktop shortcut using protocols

* URL Protocol creation and parsing

* Fix empty protocol and broken non-public commands

* Fix creation of shortcuts

* Limit commands allowed using protocols

* Better way to save the allowed commands

* Logging protocol activation

* Reorder imports and renaming variables (Code Review)

* Streamline asset copy

* Remove duplicated icons

* Experiment downloading logos from metadata

* try at getting username from steamid3

* Improve logging

* Remove assets in favour of download via metadata repo

* Fix names

* Update SteamShortcutParser.cs

* Remove old copy file section

* Remove creation of prop file, for now

* Reuse downloader from MainPage

* Asset download + verification

* UI changes

* ui changes

* Update HomePage.xaml.cs

* Dialogs for creating .url file

* Fix dialogs + Always allow adding to Steam

* UI tweaks

* Change SHA1 in favour or md5

* Localization support

* Verify is folder exists + new failure dialog

* Fix typo in namespace name

* Change metadata storage format

CollapseLauncher-ReleaseRepo/#12

* Revert changes in the CDNList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Preset Config Issue labeled for Preset/Region Configuration Bug Something isn't working Fixed Issue has been fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KorewaLidesu @neon-nyan