This repository has been archived by the owner on May 3, 2019. It is now read-only.
Switch from CMake to Qbs #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might change in then future when we'll have native plugins but for now static libs are simpler to manage...
All infrastructure unit tests are now passing again
This is annoying if you have to debug a test failure
and improve project organization
With pkg-config
and improve the target to not being run by default and always run when triggered explicitely
|
@demmm @martinkg Please try packaging this branch and report whether it works for you or not. Here is a sample from a working PKGBUILD that I use on the AUR: prepare() {
cd $srcdir/ColinDuquesnoy-MellowPlayer-${_commit}
qbs-setup-toolchains --detect
qbs-setup-qt /usr/bin/qmake-qt5 qt5
qbs-config defaultProfile qt5
}
build() {
cd $srcdir/ColinDuquesnoy-MellowPlayer-${_commit}
qbs build --no-install -d build profile:qt5 release qbs.installRoot:/usr
}
package() {
cd $srcdir/ColinDuquesnoy-MellowPlayer-${_commit}
qbs install -d build --no-build -v --install-root ${pkgdir}/usr profile:qt5 release
}@demmm you may set the default theme to midna using Here is a sample from a working specfile that I use on the openSUSE build service: %prep
%setup -q
qbs --version
qbs-setup-toolchains --detect
qbs-setup-qt /usr/bin/qmake-qt5 qt5
qbs-config defaultProfile qt5
%build
qbs build --no-install -d build release qbs.installRoot:/usr
%install
qbs install -d build --no-build -v --install-root %{buildroot}/usr release |
|
on Fedora on used this rpm spec file: the compilation fails at the end with this message:
a workaround for the moment is to remove rpath with:
the next error i get is: It means -g was missing. -g tells gcc to generate debuginfo. If there how can i solve this ? |
|
@martinkg Thanks for testing.
Does
I'd try to use |
|
@ColinDuquesnoy thanks |
|
On KaOS the gold linker error is back: |
|
there are different on fedora F28 + F29 mellowplayer qbs branch compile fine on Fedora 27 for every arch, mellowplayer qbs branch failed on fedora F28; arch: on every arch build.log |
|
@ColinDuquesnoy With latest commit (0f919a1) in qbs branch branch, builds and runs fine now on KaOS. This after adding the gold linker option. |
|
@ZeroDot1 You might want to update your script. It probably won't work on Ubuntu 17.10 anymore because their version of qbs is too old but it will work in the upcoming 18.04 release. |
|
@ColinDuquesnoy What do I have to change the script to keep it working? |
|
Well it won't work with cmake anymore so you have to change the build commands, see https://github.com/ColinDuquesnoy/MellowPlayer#from-command-line |
|
@ColinDuquesnoy I have updated the script, check if it's okay. |
|
@ZeroDot1 Thank you. That looks good. Feel free to update the wiki 😉 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to switch from cmake to qbs. Qbs (pronounced cubes) is the new build system from the Qt company that will replace qmake in the future. Qbs is much easier to use (from a developer perspective) than CMake, especially for Qt projects.
The build instructions have been updated and both AppVeyor and Travis-CI builds are passing.
I plan to merge this branch into develop in a few days. Qbs will be used for MellowPlayer 3.4 release (which I haven't started working on yet). If a bug fix is needed for version 3.3 it will be made from the master branch (with CMake).
Please try the qbs branch and report any issues you might encounter before I merge to develop.
About Qbs
Pros
Cons