Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Use custom dialogs for WebEngine dialogs #180

Closed
ColinDuquesnoy opened this issue Dec 26, 2017 · 1 comment
Closed

Use custom dialogs for WebEngine dialogs #180

ColinDuquesnoy opened this issue Dec 26, 2017 · 1 comment
Assignees
@ColinDuquesnoy
Labels
feature major UI/UX
Milestone
3.3.0

Comments

@ColinDuquesnoy
Copy link
Owner

ColinDuquesnoy commented Dec 26, 2017 •
edited
Loading

WebEngine dialogs do not match theme and are unreadable most of the times.

See https://doc.qt.io/qt-5/qtwebengine-webengine-customdialogs-example.html
@ColinDuquesnoy ColinDuquesnoy added this to the 3.3.0 milestone Dec 26, 2017
@ColinDuquesnoy ColinDuquesnoy self-assigned this Dec 26, 2017
ColinDuquesnoy added a commit that referenced this issue Dec 27, 2017
@ColinDuquesnoy
Add custom authentication dialog
bd59bf3 
See #180
ColinDuquesnoy added a commit that referenced this issue Dec 28, 2017
@ColinDuquesnoy
Authentication dialog UI/UX review with @CelineThiry
41556fe 
See #180
@ColinDuquesnoy
Copy link
Owner Author

ColinDuquesnoy commented Dec 29, 2017 •
edited
Loading

Dialog Type Before After
Authentication authenticationold authentication
Alert alertold alert
Confirm confirmold confirm
Prompt promptold prompt
Validation Message messagebubbleold messagebuble

ColinDuquesnoy added a commit that referenced this issue Dec 29, 2017
@ColinDuquesnoy
Make all webengine dialogs modal
7ddf319 
See #180
@cpjeanpaul cpjeanpaul mentioned this issue Jul 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ColinDuquesnoy ColinDuquesnoy

Labels
feature major UI/UX
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
1 participant
@ColinDuquesnoy