Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Add ability to specify list of supported platforms for a plugin #115

Closed
ColinDuquesnoy opened this issue Sep 11, 2017 · 7 comments
Closed
Assignees
Labels
Milestone

Comments

@ColinDuquesnoy
Copy link
Owner

ColinDuquesnoy commented Sep 11, 2017

Some plugin do not work on some specific platform (e.g. platform where there is no way to get proprietary codecs).

There would be a new field in the plugin metadata that is a list of supported platforms. The plugin manager would skip plugins if the current platform is not supported and the service wouldn't even show up in the services selection grid.

List of platforms:

  • All: include all supported platforms
  • Linux
  • AppImage
  • Windows
  • OSX

Example of a plugin that works only on GNU/Linux but not from an AppImage:

author=Author name
author_website=Author email
icon=logo.svg
name=ServiceName
require_proprietary_codecs=true
supported_platforms:Linux
url=https://servicename.com/
version=1.0

And here is an example of plugin that works everywhere:

author=Author name
author_website=Author email
icon=logo.svg
name=ServiceName
require_proprietary_codecs=true
supported_platforms=All
url=https://servicename.com/
version=1.0

This could even should replace the require_proprietary_codecs key.

@ZeroDot1
Copy link
Contributor

A very good feature it will help avoid confusion.
If there is the next update and new features have been added, I will do the German translation.

@ColinDuquesnoy
Copy link
Owner Author

Thank you. You will be notified by transifex when there are new strings to translate.

@ColinDuquesnoy
Copy link
Owner Author

We should also change the wizard to ask the developer of the plugin what platforms are supported.

@ZeroDot1
Copy link
Contributor

Yes

@ZeroDot1
Copy link
Contributor

The German translation is ready.

@ColinDuquesnoy ColinDuquesnoy mentioned this issue Sep 21, 2017
@ZeroDot1
Copy link
Contributor

I have just tried it, is it correct that Linux is not specified although it was selected?
bildschirmfoto_2017-09-22_21-06-00
bildschirmfoto_2017-09-22_21-08-26

author=ZeroDot1
author_website=https://goo.gl/k3nTZn
icon=logo.svg
name=Test-Plug-In
supported_platforms=AppImage,OSX
url=https://colinduquesnoy.github.io/MellowPlayer/
version=1.0

ColinDuquesnoy added a commit that referenced this issue Sep 23, 2017
@ColinDuquesnoy
Copy link
Owner Author

@ZeroDot1 No it is a bug. I fixed it. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants