Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version tag. #159

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Updated version tag. #159

merged 1 commit into from
Sep 13, 2024

Conversation

EmbeddedDevops1
Copy link
Collaborator

@EmbeddedDevops1 EmbeddedDevops1 commented Sep 13, 2024

PR Type

enhancement, configuration changes


Description

  • Updated the GitHub Actions download-artifact action from version v2 to v3 in both CI pipeline and nightly regression workflows.
  • Ensured consistency and potentially improved functionality by using the latest version of the action.

Changes walkthrough 📝

Relevant files
Configuration changes
ci_pipeline.yml
Update download-artifact action version in CI pipeline     

.github/workflows/ci_pipeline.yml

  • Updated the version of actions/download-artifact from v2 to v3.
  • Modified the download steps for Ubuntu, Windows, and macOS
    executables.
  • +3/-3     
    nightly_regression.yml
    Update download-artifact action version in nightly regression

    .github/workflows/nightly_regression.yml

  • Updated the version of actions/download-artifact from v2 to v3.
  • Modified the download step for the cover-agent artifact.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @EmbeddedDevops1 EmbeddedDevops1 self-assigned this Sep 13, 2024
    @EmbeddedDevops1 EmbeddedDevops1 merged commit 5df4c89 into main Sep 13, 2024
    1 check passed
    @EmbeddedDevops1 EmbeddedDevops1 deleted the update-download-actions-tag branch September 13, 2024 18:27
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Update the version of the checkout action to maintain consistency with other actions

    Consider updating the actions/checkout action to v3 as well, to maintain consistency
    with the actions/download-artifact action version.

    .github/workflows/ci_pipeline.yml [165]

    -- uses: actions/checkout@v2
    +- uses: actions/checkout@v3
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Updating the actions/checkout action to v3 would ensure consistency across the workflow, aligning with the updated actions/download-artifact action. This is a best practice for maintaining uniformity and potentially benefiting from improvements in the newer version.

    8

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant