-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - Add list of students #185
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d10b20f
Display the list of students
AyakorK 7fb8556
Merge branch 'develop-G10' into G10/feature/add_list_of_students
AyakorK c54de41
Modify retrieving of students infos by using the repository which is …
AyakorK 780aff6
Put some ErrorHandlers in case the API Call crashes
AyakorK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ export class CallsService { | |
constructor( | ||
@Inject(forwardRef(() => UsersRepository)) | ||
@Inject(forwardRef(() => CallsRepository)) | ||
private usersRepository: UsersRepository, | ||
public usersRepository: UsersRepository, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm. |
||
private callsRepository: CallsRepository, | ||
private jwtTokenService: JwtService, | ||
) {} | ||
|
@@ -42,4 +42,8 @@ export class CallsService { | |
const actualCourse = await this.callsRepository.getActualCourse(userId); | ||
return actualCourse; | ||
} | ||
|
||
getStudentList(courseId: CourseIdObject) { | ||
return this.callsRepository.getStudentList(courseId.courseId); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,11 @@ | |
<div v-else> | ||
<p>{{ message }}</p> | ||
</div> | ||
<div v-if="studentList"> | ||
<div v-for="student in studentList" :key="student.id"> | ||
<p>{{ student.profile.firstName }} {{ student.profile.lastName }}</p> | ||
</div> | ||
</div> | ||
</div> | ||
</template> | ||
|
||
|
@@ -14,6 +19,7 @@ import { http } from '@/api/network/axios'; | |
let url = ''; | ||
let courseId = ''; | ||
let message = ''; | ||
let studentList = []; | ||
|
||
export default { | ||
name: 'QrCode', | ||
|
@@ -25,6 +31,7 @@ export default { | |
url, | ||
courseId, | ||
message, | ||
studentList, | ||
QrGen: '', | ||
}; | ||
}, | ||
|
@@ -54,11 +61,18 @@ export default { | |
isThereCourse() { | ||
if (this.courseId) { | ||
this.getQrCode(); | ||
this.getStudentList(); | ||
this.message = ''; | ||
} else { | ||
this.message = "Vous n'avez pas de cours aujourd'hui"; | ||
} | ||
}, | ||
|
||
getStudentList() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use -> getStudentList: withErrorHandler(async function() { If the call return an error, your page crash. |
||
http.get(`/calls/student_list/${this.courseId}`).then((response) => { | ||
this.studentList = response.data.studentList; | ||
}); | ||
}, | ||
}, | ||
}; | ||
</script> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using Promise.all(...)
You can do : collection.find( { _id: { $in: [ObjectId("id"),...,...] } }).toArray()