[Feature] - Add list of students #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Maghwyn
requested changes
Mar 23, 2023
| @UseGuards(JwtAuthGuard) | ||
| async studentList(@Param() courseId: CourseIdObject, @Res() res: Response) { | ||
| const studentIdList = await this.callsService.getStudentList(courseId); | ||
| const studentList = await Promise.all( |
There was a problem hiding this comment.
Instead of using Promise.all(...)
You can do : collection.find( { _id: { $in: [ObjectId("id"),...,...] } }).toArray()
| @@ -11,7 +11,7 @@ export class CallsService { | |||
| constructor( | |||
| @Inject(forwardRef(() => UsersRepository)) | |||
| @Inject(forwardRef(() => CallsRepository)) | |||
| private usersRepository: UsersRepository, | |||
| public usersRepository: UsersRepository, | |||
| this.message = ''; | ||
| } else { | ||
| this.message = "Vous n'avez pas de cours aujourd'hui"; | ||
| } | ||
| }, | ||
|
|
||
| getStudentList() { |
There was a problem hiding this comment.
use -> getStudentList: withErrorHandler(async function() {
...
})
If the call return an error, your page crash.
|
Kudos, SonarCloud Quality Gate passed!
|
Maghwyn
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been made to print the list of students of a same class in the scan zone