Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Add New" btn in Submission Dashboard #1813

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 11, 2023

Closes #1810

Summary

Add CSS to hide the "Add New" button. This way it will prevent the user from accidentally creating a submission.


Test instructions

  • Install Otter Pro on a WordPress multisite installation.
  • Create multiple sites and visit one of them while being logged in using the super admin user of the network
  • Visit Otter Blocks > Form Submissions -> There is should NO "Add New" button.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel changed the base branch from master to development August 11, 2023 12:54
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 11, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 11, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 11, 2023 12:59
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.78 KB 270.78 KB 0 B (0.00%)
Blocks 1.41 MB 1.41 MB 0 B (0.00%)
CSS 85.28 KB 85.28 KB 0 B (0.00%)
Dashboard 122.49 KB 122.49 KB 0 B (0.00%)
Export Import 83.17 KB 83.17 KB 0 B (0.00%)
Pro 302.52 KB 302.52 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 11, 2023

Plugin build for 3c41ba6 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 11, 2023

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 70.28 9.37 67.73 0 (60ms) 84.21 (80ms)
Values above 60ms "0 - 73.47, 1 - 60.58, 2 - 61.62, 3 - 63.86, 4 - 70.07, 5 - 63.74, 6 - 63.03, 7 - 65.11, 8 - 69.02, 9 - 67.50, 10 - 96.22, 11 - 63.44, 12 - 70.38, 13 - 91.40, 14 - 81.03, 15 - 68.30, 16 - 72.90, 17 - 67.73, 18 - 65.99"

@Soare-Robert-Daniel Soare-Robert-Daniel changed the title Fix/submission-multisite Hide "Add New" btn in Submission Dashboard Aug 11, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 11, 2023
@HardeepAsrani HardeepAsrani merged commit 8a99b08 into development Aug 21, 2023
@HardeepAsrani HardeepAsrani deleted the fix/submission-multisite branch August 21, 2023 23:40
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PRO]Fatal error in Form Submissions page by super admin users on multisite network
3 participants