Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRO]Fatal error in Form Submissions page by super admin users on multisite network #1810

Closed
rodica-andronache opened this issue Aug 11, 2023 · 4 comments · Fixed by #1813
Closed

[PRO]Fatal error in Form Submissions page by super admin users on multisite network #1810

rodica-andronache opened this issue Aug 11, 2023 · 4 comments · Fixed by #1813
Assignees
@Soare-Robert-Daniel
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Milestone
2.3.4

Comments

@rodica-andronache
Copy link

Description

https://www.loom.com/share/ebef64bd53974499b86193006ea74bb4?sid=ed44332a-07b6-4b84-9bf7-6f4db009014f

Step-by-step reproduction instructions

  1. Install Otter Pro on a WordPress multisite installation.
  2. Create multiple sites and visit one of them, while being logged in using the super admin user of the network
  3. Visit Otter Blocks > Form Submissions -> There is an extra Add New button, which if you click on, it will give a fatal error

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot on 2023-08-11 at 14-48-12

Environment info

No response

Is the issue you are reporting a regression

No
@rodica-andronache rodica-andronache added the bug This label could be used to identify issues that are caused by a defect in the product. label Aug 11, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Aug 11, 2023
Merged
9 tasks
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Aug 11, 2023 that will close this issue
Hide "Add New" btn in Submission Dashboard #1813
Merged
9 tasks
@rodica-andronache
Copy link
Author

@Soare-Robert-Daniel it's working well, except when Elementor is activated. In that case, the Add new button is still there, unless I add !important for the css line

@Soare-Robert-Daniel
Copy link
Contributor

I added a special condition for the Elementor case. A very interesting case is the fact that when pressing the button no crash happens.

Also tested a few other blocks plugin to check if they add some extra CSS.

@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Aug 16, 2023
@rodica-andronache
Copy link
Author

@rodica-andronache everything's working well now 👍

@HardeepAsrani HardeepAsrani mentioned this issue Aug 21, 2023
Merged
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HardeepAsrani HardeepAsrani added this to the 2.3.4 milestone Aug 23, 2023
@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
2.3.4
Development

Successfully merging a pull request may close this issue.

Hide "Add New" btn in Submission Dashboard Codeinwp/otter-blocks
4 participants
@HardeepAsrani @rodica-andronache @Soare-Robert-Daniel @pirate-bot