Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust z-index for section dividers #1780

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jul 31, 2023

Closes #1751.

Summary

Adjust section dividers so they can be behind the content but in front of the background.

Screenshots

image


Test instructions

  1. Make a section block with content.
  2. Insert the dividers.
  3. Ensure the dividers are behind the content but in front of the Section background.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 31, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jul 31, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review July 31, 2023 13:33
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Jul 31, 2023 that may be closed by this pull request
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 192.38 KB 192.38 KB 0 B (0.00%)
Blocks 1.34 MB 1.34 MB 0 B (0.00%)
CSS 6.9 KB 6.9 KB 0 B (0.00%)
Dashboard 44.4 KB 44.4 KB 0 B (0.00%)
Export Import 4.7 KB 4.7 KB 0 B (0.00%)
Pro 225.44 KB 225.44 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 31, 2023

Plugin build for a564d84 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 31, 2023

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 51.29 8.09 49.2 89.47 (60ms) 100 (80ms)
Values above 60ms "1 - 79.69, 5 - 61.57"

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 1, 2023
@rodica-andronache
Copy link

@Soare-Robert-Daniel everything's working well 🚀

@HardeepAsrani HardeepAsrani merged commit 3861428 into development Aug 21, 2023
@HardeepAsrani HardeepAsrani deleted the fix/section-divider-z branch August 21, 2023 23:39
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shape divider for Section block z index issue
4 participants