Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape divider for Section block z index issue #1751

Closed
mghenciu opened this issue Jul 4, 2023 · 5 comments · Fixed by #1780
Closed

Shape divider for Section block z index issue #1751

mghenciu opened this issue Jul 4, 2023 · 5 comments · Fixed by #1780
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Milestone

Comments

@mghenciu
Copy link
Contributor

mghenciu commented Jul 4, 2023

Description

As seen in the Screenshot, the Shape divider is above the section content - which shouldn't be the case.

Step-by-step reproduction instructions

  1. Create a fresh instance with Otter and Neve
  2. Add this Sections inside a page (attached)
  3. Notice the Shape divider position

shape-divider-sections.json.zip

Can also be tested here: https://demosites.io/product-launch-gb/preorder

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot 2023-07-04 at 16 34 15

Environment info

https://pastebin.com/FNmW4jB7

Is the issue you are reporting a regression

No

@mghenciu mghenciu added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 4, 2023
@mghenciu
Copy link
Contributor Author

Hey @HardeepAsrani @Soare-Robert-Daniel , what do you think if we prioritise this issue?

I am asking this since the issue is still in the Up Next column, and this bug is very visible and can affect the users in a more profund way, to the point where the Shape divider feature can't be used.

@Soare-Robert-Daniel
Copy link
Contributor

@mghenciu Regarding this issue, we had some time ago a similar problem: #1597, which led to this PR #1606 in which I made the divider to be on top of the content.

I will make a version in which both dividers are behind the content.

@Soare-Robert-Daniel Soare-Robert-Daniel added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Jul 31, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Jul 31, 2023 that will close this issue
9 tasks
@Soare-Robert-Daniel
Copy link
Contributor

You can test this on #1780

@mghenciu
Copy link
Contributor Author

mghenciu commented Aug 1, 2023

You can test this on #1780

Looks good in Front-end.
In Backend I think it needs some work, since the Shapes are stil above the content (attached)
Screenshot 2023-08-01 at 09 05 25

Test Instance:
https://kindlyoven.s1-tastewp.com/wp-admin admin | Bn9Pt1MdqTo

@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HardeepAsrani HardeepAsrani added this to the 2.3.4 milestone Aug 23, 2023
@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants