Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW6/Ayman-matoo/Html Css /Bikes for refugees /week 1 #484

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
270 changes: 143 additions & 127 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,158 +21,174 @@

<body>
<div class="header">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This div isn't semantic, it's a generic html tag. Mayble look at the class string as a clue to make it semantic!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thank

<a href="#">
<img
src="images/bikes-for-refugees_logo.jpg"
alt="Logo for Bikes for Refugees Scotland"height="60px"width="06px";
class="header__logo"
/>
</a>

<div>
<ul class="navigation__list">
<li class="navigation__item">
<a class="navigation__link" href="#">Home</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">About Us</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">News & Events</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">Contact Us</a>
</li>
</ul>
</div>

<a href="#">
<img
src="images/bikes-for-refugees_logo.jpg"
alt="Logo for Bikes for Refugees Scotland"
class="header__logo"
/>
</a>

<div>
<ul class="navigation__list">
<li class="navigation__item">
<a class="navigation__link" href="#">Home</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">About Us</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">News & Events</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">Contact Us</a>
</li>
</ul>
</div>

<button>Donate Now</button>

<button>
<a href="https://codeyourfuture.io/donate/"> Donate Now </a>
</button>
</div>

<div class="content">
<div class="main">
<div class="alert">
You've helped us give <span class="text-highlight">72</span> bikes
to refugees and asylum seekers so far. <strong>Thank you!</strong>
</div>
<div class="main">
<div class="alert">
You've helped us give <span class="text-highlight">72</span> bikes to
refugees and asylum seekers so far. <strong>Thank you!</strong>
</div>

<div class="hero">
<h1>Bikes for Refugees</h1>
<p>
Providing donated bikes and accessories to refugees and asylum
seekers in Scotland.
</p>
<button>Donate a bike today</button>
<button>Volunteer</button>
<div class="hero">
<h1>Bikes for Refugees</h1>
<p>
Providing donated bikes and accessories to refugees and asylum
seekers in Scotland.
</p>
<div class="button-div">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add this div in. As mentioned the divs are not semantic, whereas the button tag is.

<button>
<a
href="https://www.cyclistsfc.org.uk/manchester-cfc-charity-bike-shop.php"
>Donate a bike today
</a>
</button>

<button class="vol1">
<a href="https://codeyourfuture.io/volunteers/">Volunteer</a>
</button>
</div>
</div>

<div>
<h2 class="heading-underline">Learn more</h2>

<div>
<div class="article">
<h3 class="article__title">Why do refugees need bikes?</h3>
<p class="article__summary">
Many refugees are placed in housing in areas where there are
few jobs. Bikes provide low-cost transportation so that they
can get to work, manage child care and do their shopping.
</p>
<p class="article__read-more">
<a href="#">
<span class="arrow-right"></span>
Learn more
</a>
</p>
</div>

<div class="article">
<h3 class="article__title">How can I help?</h3>
<p class="article__summary">
We need lots of bikes and bike accessories! If you have an
old bike you don't use, bring it to one of our dropoff
events. Or come attend one of our fundraisers.
</p>
<p class="article__read-more">
<a href="#">
<span class="arrow-right"></span>
Learn more
</a>
</p>
</div>
<div>
<h2 class="heading-underline">Learn more</h2>
<div class="articleArea">
<div class="article">
<h3 class="article__title">Why do refugees need bikes?</h3>
<p class="article__summary">
Many refugees are placed in housing in areas where there are few
jobs. Bikes provide low-cost transportation so that they can get
to work, manage child care and do their shopping.
</p>
<p class="article__read-more">
<a href="#">
<span class="arrow-right"></span>
Learn more
</a>
</p>
</div>
</div>
</div>

<div class="sidebar">
<h2 class="heading-underline">Upcoming events</h2>

<div class="article">
<img
class="article__thumbnail"
src="spring-fundraisers_thumbnail.jpg"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#">Join us for our Spring fundraisers</a>
</h3>
<div class="article">
<h3 class="article__title">How can I help?</h3>
<p class="article__summary">
Riders needed now to help raise awareness and funds for BfR and
Médecins Sans Frontières.
We need lots of bikes and bike accessories! If you have an old
bike you don't use, bring it to one of our dropoff events. Or
come attend one of our fundraisers.
</p>
<p class="article__read-more">
<a href="#">
<span class="arrow-right"></span>
Learn more
</a>
</p>
</div>
</div>
</div>
</div>

<div class="article">
<img
class="article__thumbnail"
src="bikes-for-refugees_logo.jpg"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#">Bike dropoff event in Edinburgh on May 11</a>
</h3>
</div>
<div class="sidebar">
<h2 class="heading-underline">Upcoming events</h2>

<div class="article">
<img
class="article__thumbnail"
src="spring-fundraisers_thumbnail.jpg"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#"
>Join us for our Spring fundraisers</a
>
</h3>
<p class="article__summary">
Riders needed now to help raise awareness and funds for BfR and
Médecins Sans Frontières.
</p>
</div>
</div>

<div class="article">
<img
class="article__thumbnail"
src="edinburgh-damascus_thumbnail.png"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#">Help us cycle 4,797km</a>
</h3>
<p class="article__summary">
We need you to help us cycle 4797km, the distance of Edinburgh
to Damascus.
</p>
</div>
<div class="article">
<img
class="article__thumbnail"
src="bikes-for-refugees_logo.jpg"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#"
>Bike dropoff event in Edinburgh on May 11</a
>
</h3>
</div>
</div>

<a
href="https://www.facebook.com/BikesforRefugeesScotland/events/?ref=page_internal"
target="_blank"
class="facebook-link"
>
<span class="fa fa-facebook-square"></span>
All Facebook events
</a>
<div class="article">
<img
class="article__thumbnail"
src="edinburgh-damascus_thumbnail.png"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#">Help us cycle 4,797km</a>
</h3>
<p class="article__summary">
We need you to help us cycle 4797km, the distance of Edinburgh to
Damascus.
</p>
</div>
</div>

<a
href="https://www.facebook.com/BikesforRefugeesScotland/events/?ref=page_internal"
target="_blank"
class="facebook-link"
>
<span class="fa fa-facebook-square"></span>
All Facebook events
</a>
</div>
</div>

<div class="footer">
<div class="footer__content">
<p>
<strong>Bikes for Refugees Scotland is a volunteer-led project to help
people explore and make connections with their local communities.</strong>
<strong
>Bikes for Refugees Scotland is a volunteer-led project to help
people explore and make connections with their local
communities.</strong
>
</p>
<p>Website by Code Your Future</p>
<p><b>Website by Code Your Future</b></p>
</div>
</div>
</body>
Expand Down
25 changes: 24 additions & 1 deletion styles/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ p {


/* Buttons */
button{
background-color: var(--orange-dark);
color: var(--white);
border-radius: none;
padding: 0.5rem;
}

/* INSERT BUTTON STYLES HERE */

Expand All @@ -120,16 +126,19 @@ p {
/* hero */

.hero {
background-image: url("header-bike.jpg");
background-image: url("/images/header-bike.jpg");
background-color: var(--grey-light);
padding-bottom: 160px;
}

.hero h1 {
color: #fff;
margin-bottom: 1rem;
font-size: 2.5rem;
}

.hero p {
color: #e4e4e4;
font-size: 1.2rem;
margin-bottom: 2rem;
}
Expand Down Expand Up @@ -160,9 +169,20 @@ p {


/* Article */
.articleArea {
display: flex;
flex-direction: row;
column-gap: 12px;
padding-left: 5px;
}

.article {

border: 1px solid grey;
margin-bottom: 1rem;
padding-left: 4p;
display: table-cell;
margin-inline-start ;
}

.article__title {
Expand All @@ -178,6 +198,7 @@ p {

.article__summary {
margin-top: 0;
padding-left: 5px;
margin-bottom: 1rem;
}

Expand Down Expand Up @@ -236,6 +257,8 @@ p {
text-align: center;
font-size: 0.85rem;
}
.vol1{ background-color: white;}
.button-div{ margin-top: 6em ;}

/* Media queries */

Expand Down