NW6/Ayman-matoo/Html Css /Bikes for refugees /week 1 #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-bfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Honestocean
changed the title
Honestocean
changed the title
Honestocean
changed the title
Honestocean
reviewed
Nov 11, 2023
index.html
Outdated
| @@ -21,158 +21,174 @@ | |||
|
|
|||
| <body> | |||
| <div class="header"> | |||
There was a problem hiding this comment.
This div isn't semantic, it's a generic html tag. Mayble look at the class string as a clue to make it semantic!
Honestocean
reviewed
Nov 11, 2023
| Providing donated bikes and accessories to refugees and asylum | ||
| seekers in Scotland. | ||
| </p> | ||
| <div class="button-div"> |
There was a problem hiding this comment.
You don't need to add this div in. As mentioned the divs are not semantic, whereas the button tag is.
Ayman-matoo
changed the title
Ayman-matoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.