Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tightened up the inspector UI design to make it more consistent #949

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Tightened up the inspector UI design to make it more consistent #949

merged 2 commits into from
Jan 13, 2023

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Jan 13, 2023

Description

Refined the inspector UI to be more consistent with Xcode. In the future we plan to customize to improve this design but it is good to start with a good foundational design.

I also created two new views, InspectorSection and InspectorField. This way we can reuse this design without having to repeat ourselves. It allowed me to delete a good amount of code. We may later make these kinds of Views available for extension developers to create their own Inspectors.

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Before

image

After

image

Xcode

image

lukepistrol
lukepistrol previously approved these changes Jan 13, 2023
@0xWDG 0xWDG assigned 0xWDG and unassigned 0xWDG Jan 13, 2023
@austincondiff austincondiff merged commit 52e6898 into CodeEditApp:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants