fix: Searchkit memory leaks #1735
Merged
+21
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wouter01
approved these changes
May 24, 2024
matthijseikelenboom
approved these changes
May 24, 2024
0xWDG
approved these changes
May 24, 2024
FastestMolasses
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some memory leaks that occurred during the retrieval of search results from SearchKit. This was because I wrongfully used .takeUnretainedValue(), which caused the memory count to be off, leading to thousands of objects not being deinitialized.
I reviewed all the code that uses SearchKit and corrected other instances of wrongful use of .takeUnretainedValue() or .takeRetainedValue().
During profiling, there should no longer be any memory leaks connected to SearchKit.
Related Issues
Checklist
Screenshots