Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞Memory Leaks in SearchKit Result Retrieval #1736

Closed
tom-ludwig opened this issue May 24, 2024 · 0 comments · Fixed by #1735
Closed

🐞Memory Leaks in SearchKit Result Retrieval #1736

tom-ludwig opened this issue May 24, 2024 · 0 comments · Fixed by #1735
Assignees
Labels
bug Something isn't working performance This is performance related triage needed

Comments

@tom-ludwig
Copy link
Member

Description

There have been persistent memory leaks observed during the retrieval of search results from SearchKit. The root cause was identified as the incorrect use of .takeUnretainedValue() method. This misuse led to a discrepancy in the memory management, resulting in thousands of objects not being deinitialized properly. The memory leaks caused an increase in memory usage over time, potentially degrading the performance of the app.

To Reproduce

  1. Perform multiple search operations using the SearchKit.
  2. Monitor the memory usage through a profiling tool.
  3. The number of leaks should increase every time you perform a search.

Expected Behavior

At the end of the function the RefCount should be 0 for each object form SeachKit.

Version Information

CodeEdit: 0.1.0-dev (38)
macOS: 15.4
Xcode: 14.5

Additional Context

No response

Screenshots

Screenshot 2024-05-24 at 2 26 26 PM Screenshot 2024-05-24 at 2 25 00 PM Screenshot 2024-05-24 at 2 24 38 PM
@tom-ludwig tom-ludwig added bug Something isn't working performance This is performance related labels May 24, 2024
@tom-ludwig tom-ludwig self-assigned this May 24, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance This is performance related triage needed
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

1 participant