Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix misplaced terminal icon in macOS Sonoma #1436

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: Fix misplaced terminal icon in macOS Sonoma #1436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions CodeEdit/Features/UtilityArea/TerminalUtility/UtilityAreaTerminalTab.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,16 @@ struct UtilityAreaTerminalTab: View {
)

Label {
TextField("Name", text: terminalTitle)
.focused($isFocused)
.padding(.leading, -8)
if #available(macOS 14, *) {
// Fix the icon misplacement issue introduced since macOS 14
TextField("Name", text: terminalTitle)
.focused($isFocused)
} else {
// A padding is needed for macOS 13
TextField("Name", text: terminalTitle)
.focused($isFocused)
.padding(.leading, -8)
}
} icon: {
Image(systemName: "terminal")
}
Expand Down