fix: Fix misplaced terminal icon in macOS Sonoma #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qian Qian "Cubik" <[email protected]>
thecoolwinter
approved these changes
Sep 26, 2023
|
https://discord.com/channels/951544472238444645/952640818068463667/1155687395916795964 More discussion posted here w/ screenshots & OS comparison. |
austincondiff
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a negative padding for
TextField, which causes issues on macOS 14. But, removing it makes the gap (for macOS 13 and earlier) between the icon and the title too large, so there's a system specific check to not cause issue on older OS.Related Issues
Checklist
Screenshots