dbus rework #43
Merged
dbus rework #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements the dbus interface rework specified in #40. Essentially: this uses more standard bus, object and path names, and moves away from the xyz.openbmc_project namespace, and use au.com.codeconstruct (all lowercase) there instead, as we're not specificially an OpenBMC project. We also put collections of things (networks and endpoints) under a specifically-named object path, so we can introduce new collections alongside (interfaces) without compatibility issues This means: - the bus owner name is now au.com.codeconstruct.MCTP1 - interfaces are namespaced and versioned: - au.com.codeconstruct.MCTP.Endpoint1 - au.com.codeconstruct.MCTP.BusOwner1 - the top-level entrypoint path is versioned, as `/au/com/codeconstruct/mctp1` - the endpoint object tree is structured as `/au/com/codeconstruct/mctp1/networks/<n>/endpoints/<e>` Signed-off-by: Jeremy Kerr <[email protected]>
We'll be modifying this for the new Role-based interfaces which exist on the link/interface objects, so use a temporary name for now. Signed-off-by: Jeremy Kerr <[email protected]>
Enumerate the parent D-Bus object path `.../mctp1/networks` for the
network paths `.../mctp1/networks/<NetID>` and
`.../mctp1/networks/<NetID>/endpoints` for the endpoints path
`.../mctp1/networks/<NetID>/endpoints/<EID>`.
Tested:
Check the MCTP D-Bus interface:
```
busctl tree au.com.codeconstruct.MCTP1
`- /au
`- /au/com
`- /au/com/codeconstruct
`- /au/com/codeconstruct/mctp1
`- /au/com/codeconstruct/mctp1/networks
`- /au/com/codeconstruct/mctp1/networks/1
`- /au/com/codeconstruct/mctp1/networks/1/endpoints
`- /au/com/codeconstruct/mctp1/networks/1/endpoints/8
```
Signed-off-by: Thu Nguyen <[email protected]>
Signed-off-by: Jeremy Kerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the dbus rework discussed in #40. From the interface commit:
Closes: #40