Merging Storybook Next into fork #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.3 went from emotion 10 to emotion 9, causing issues with code dedupe for us (since yarn decided to hoist differently). 2.3 is still en semver range here, but this allows us to lock down the older version
…n-lit-html element It seems the mountNode becomes stateful after a render has occurred in lit-html. Since storybook is changing the dom beyond lit-html, it gets "confused" and throws an error because it's unable to remove some nodes. I guess it's trying to do reconciliation or cleanup, and it's missing state or it's state is inconsistent with the actual dom. By adding a extra inner root node that gets reset when switching stories we make lit-html mount correctly
Corrected import path for `themes`
fix: move `react-select` dependency to 2.2
# Conflicts: # addons/knobs/package.json # yarn.lock
# Conflicts: # lib/theming/src/create.ts
…quiet to static standalone command
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
CodeByAlex
pushed a commit
that referenced
this pull request
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.