Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected import path for themes #5870

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Corrected import path for themes #5870

merged 1 commit into from
Mar 5, 2019

Conversation

tzkuei
Copy link
Contributor

@tzkuei tzkuei commented Mar 5, 2019

Issue:

Incorrect import path for themes in example.

What I did

Corrected import path for themes.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? Yes

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Mar 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot requested a deployment to staging March 5, 2019 09:42 Abandoned
@vercel
Copy link

vercel bot commented Mar 5, 2019

Deployment failed with the following error:

Builds rate limit exceeded (0 of 100 remaining). Try again in 24h

@ndelangen ndelangen self-assigned this Mar 5, 2019
@ndelangen ndelangen merged commit c79dae4 into storybookjs:next Mar 5, 2019
@ndelangen
Copy link
Member

Thank you @tzkuei ! 👍

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 5, 2019
@tzkuei tzkuei deleted the patch-4 branch March 6, 2019 10:10
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzkuei @ndelangen @shilman